Disable gocritic and re-enable wastedassign #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
review-linters
branch
from
72712bc to
f7902e9
Compare
mihaitodor
commented
Mar 19, 2023
| if mediaType, params, err = mime.ParseMediaType(contentType); err != nil { | ||
| h.log.Warnf("Failed to parse media type from Content-Type header: %v\n", err) | ||
| } | ||
| err = nil |
Contributor
Author
There was a problem hiding this comment.
I think it makes more sense for this method to not use named return parameters
- gogritic is very slow (golangci-lint v1.52.0) - wastedassign received support for generics: golangci/golangci-lint#3689 - Refactor httpclient.Client.ResponseToBatch to fix wastedassign warning
mihaitodor
force-pushed
the
review-linters
branch
from
f7902e9 to
310bf15
Compare
Jeffail
approved these changes
Mar 21, 2023
Collaborator
Jeffail
left a comment
Jeffail
left a comment
There was a problem hiding this comment.
Niccceeeee, thanks for looking into this, that's a massive win ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LE: Looks like the PR liniting time went down from 7 to 2 minutes