-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-1458 rename BYOVPC on Azure to BYOVNet #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe documentation was updated to standardize and clarify terminology related to network deployment options for Redpanda Cloud BYOC clusters. All references to "BYOVPC" in the context of Azure were changed to "BYOVNet" to accurately reflect Azure's use of Virtual Networks (VNet) instead of Virtual Private Clouds (VPC). Section titles, feature lists, shared responsibility tables, and descriptive text were revised to consistently use "BYOVPC/BYOVNet" when referring to customer-managed networks across AWS, GCP, and Azure. No procedural, code, or technical instructions were altered. Assessment against linked issues
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
david-yu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thank you!
kbatuigas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion to look into but no blockers otherwise!
| :description: Connect Redpanda Cloud to your existing VNet for additional security. | ||
| :page-beta: true | ||
|
|
||
| include::shared:partial$feature-flag-rpcn.adoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This partial at the top still only says BYOVPC: https://deploy-preview-335--rp-cloud.netlify.app/redpanda-cloud/get-started/cluster-types/byoc/azure/vnet-azure/ do we need to change it there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kat! I updated the partial.
Description
This pull request updates documentation to standardize terminology by replacing "BYOVPC" with "BYOVNet" where applicable, reflecting the support for both Virtual Private Clouds (VPCs) and Virtual Networks (VNets).
Terminology Standardization:
modules/get-started/pages/cloud-overview.adocto reflect support for both VPCs and VNets across AWS, GCP, and Azure. [1] [2]Feature Availability Updates:
These changes ensure consistency across the documentation and improve clarity for users managing Redpanda clusters in different cloud environments.
Resolves https://redpandadata.atlassian.net/browse/DOC-1458
Review deadline:
Page previews
Cloud Overview
Create a BYOVNet Cluster on Azure
Checks