-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-1444 use different property in cluster config example #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1444 use different property in cluster config example #322
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe documentation for cluster configuration has been updated to replace all example references to the Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/manage/pages/cluster-maintenance/config-cluster.adoc (1)
68-74: Inline comment needs update to reflectaudit_enabled
The curl command comment still says "enable data transforms" but the payload now setsaudit_enabled. Update the comment for consistency.Apply this diff:
- # Update your cluster configuration to enable data transforms. + # Update your cluster configuration to enable audit logging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/manage/pages/cluster-maintenance/config-cluster.adoc(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (4)
modules/manage/pages/cluster-maintenance/config-cluster.adoc (4)
31-36: CLI example correctly updated to useaudit_enabled
The description and therpk cluster config setcommand now referenceaudit_enabledinstead ofdata_transforms_enabled, aligning with the PR objective.
58-63: Cloud API PATCH example updated toaudit_enabled
The explanatory text now referencesaudit_enabled, and the JSON payload in the PATCH example matches the updated property name.
114-119: CLI get example correctly updated to useaudit_enabled
Therpk cluster config getexample now shows the correctaudit_enabledproperty.
128-131: Cloud API GET description updated to reflectaudit_enabled
The GET request example and its description now referenceaudit_enabled, matching the set example above.
Description
This pull request updates the documentation in
modules/manage/pages/cluster-maintenance/config-cluster.adocto replace references to thedata_transforms_enabledcluster property with theaudit_enabledproperty. The changes ensure consistency across examples and instructions for setting and retrieving cluster configuration properties.Documentation updates:
Updated examples to use
audit_enabledinstead ofdata_transforms_enabledin instructions for setting cluster properties withrpk(rpk cluster config set) and Cloud API (PATCH /v1/clusters/{cluster.id}). [1] [2] [3]Updated examples to use
audit_enabledinstead ofdata_transforms_enabledin instructions for retrieving cluster property values withrpk(rpk cluster config get) and Cloud API (GET /clusters/{cluster.id}). [1] [2]Resolves https://redpandadata.atlassian.net/browse/DOC-1444
Review deadline:
Page previews
Config cluster properties
Checks