-
Notifications
You must be signed in to change notification settings - Fork 4
Fix ordered list #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordered list #319
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change corrects a JSON syntax error by removing a trailing comma from the permissions array in the Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
98e4919 to
c056ac2
Compare
Description
This pull request standardizes the formatting of JSON role definitions by removing trailing commas from permission arrays across multiple files. Additionally, it removes an anchor ID to fix an order list on the page.
Changes to JSON role formatting:
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc(redpanda-connect-api.role,redpanda-connect.role) [1] [2]modules/get-started/pages/cluster-types/byoc/gcp/enable-secrets-byovpc-gcp.adoc(redpanda-operator.role,redpanda-cluster.role) [1] [2]modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc(multiple roles includingredpanda-agent.role,redpanda-cluster.role,redpanda-operator.role,redpanda-connect-api.role,redpanda-connect.role,redpanda-console.role,redpanda-connectors.role,redpanda-gke.role) [1] [2] [3] [4] [5] [6] [7] [8] [9]Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
https://deploy-preview-319--rp-cloud.netlify.app/redpanda-cloud/get-started/cluster-types/byoc/gcp/enable-secrets-byovpc-gcp/
Checks