fixed - xcaim method should verify minIdleTime not idleTime #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinia91
force-pushed
the
fix-xcaim-validation
branch
from
239caa4 to
6a9753d
Compare
Signed-off-by: jinia91 <[email protected]>
jinia91
force-pushed
the
fix-xcaim-validation
branch
from
6a9753d to
bd8fba5
Compare
Member
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xClaim command interface in Spring Data Redis takes minIdleTime as an option. However, in the current implementation of xClaim in Redisson, it validates idleTime instead of minIdleTime, which causes a NullPointerException (NPE).
This PR fixes the validation to properly handle minIdleTime.
issue: #6192