Update actions for node20 on GitHub runners

[boidolr]

Resolve deprecation warnings, see https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Note that similar changes are needed for actions/upload-artifact and actions/download-artifact as well. Those bring incompatibilities with their uploads/downloads though, so might need some coordination: https://github.com/actions/upload-artifact/releases/tag/v4.0.0

[enjoy-binbin]

#13023, i have tried this before, do you have a solution for the following error?

https://github.com/redis/redis/actions/runs/7951767309/job/21709474198?pr=13061

Post job cleanup.
/usr/bin/docker exec  901d9f04b6e6f1f596d05936e77b5fd05ee3d9e3f[2](https://github.com/redis/redis/actions/runs/7951767309/job/21709474198?pr=13061#step:7:2)a882b0c91eb725[3](https://github.com/redis/redis/actions/runs/7951767309/job/21709474198?pr=13061#step:7:3)2ad9d2b sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib6[4](https://github.com/redis/redis/actions/runs/7951767309/job/21709474198?pr=13061#step:7:4)/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.2[5](https://github.com/redis/redis/actions/runs/7951767309/job/21709474198?pr=13061#step:7:5)' not found (required by /__e/node20/bin/node)

[boidolr]

I think this might be because that particular runner is using "container: centos:7" which seem to be missing some libraries needed to run the node20 checkout action. Therefore updating the image might resolve the issue.
I've updated the PR to omit that particular job.

[enjoy-binbin]

If we ignore it, wouldn't there still be task getting deprecation warnings?

[boidolr]

Interestingly, those do not emit those warnings. Currently the jobs where this warnings turned up where:

• https://github.com/redis/redis/actions/workflows/external.yml
• https://github.com/redis/redis/actions/workflows/spell-check.yml
• https://github.com/redis/redis/actions/workflows/reply-schemas-linter.yml
• https://github.com/redis/redis/actions/workflows/daily.yml
• https://github.com/redis/redis/actions/workflows/codeql-analysis.yml

I am not sure why the other runners in ci do not show that warning - I have seen it in other repos. For consistency between the workflows I had planned to update all usages of these actions. Though for now it seems it is possible to skip the one failing job. How do you want to proceed?

[enjoy-binbin]

my thought is to either upgrade actions to v4, or not upgrade and stay at v3 and wait for this issue to be solved actions/checkout#1487

[boidolr]

Ok got it. Sorry for the noise then.

Closing this as a duplicate of #13023