Refactor search index to improve connection handling #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs333
approved these changes
Jul 30, 2024
Collaborator
rbs333
left a comment
rbs333
left a comment
There was a problem hiding this comment.
Looks like improvement to me. Key takeaway to use the new decorated .set_client
Collaborator
Author
Yes, for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were leaning on a hack to run some async code in a sync setting. This was both dangerous and an anti-pattern. We also needed to refactor some of the shared and non-shared content between the BaseSearchIndex and derivatives.