Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add XAUTOCLAIM command, added to Redis in 6.2 #1018

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

alexmreis
Copy link
Contributor

@alexmreis alexmreis commented Jul 12, 2021

This adds support for the XAUTOCLAIM command, which was added in Redis 6.2.0.

I tried to imitate the API/wording and hashifying of similar functions, let me know if there is anything I need to change

Ref: #978

@alexmreis
Copy link
Contributor Author

@rhymes @byroot XAUTOCLAIM implementation is done for #978 . Could you maybe have a look and comment/approve?

@byroot
Copy link
Collaborator

byroot commented Jul 13, 2021

I got the first notification. I'll get to it when I have a bit of time. Thanks for your patience.

@alexmreis
Copy link
Contributor Author

I got the first notification. I'll get to it when I have a bit of time. Thanks for your patience.

Sorry for the double notification! Wasn't sure if you were automatically notified. Thanks for considering this PR 🙏

lib/redis.rb Outdated Show resolved Hide resolved
lib/redis.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@byroot byroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, otherwise LGTM.

lib/redis.rb Outdated Show resolved Hide resolved
@byroot byroot merged commit baf5706 into redis:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants