-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Description
I will look into and work on the follows failure later.
Pub / Sub tests on cluster
The Pub/Sub channel tends to remain after another test case. The channel prefix is duplicated between chanel* and channel*. It is just need to change the channel name.
4) Failure:
TestClusterCommandsOnPubSub#test_publish_psubscribe_punsubscribe_pubsub [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_pub_sub_test.rb:90]:
--- expected
+++ actual
@@ -1 +1 @@
-{"chanel1"=>"one", "chanel2"=>"two", "hermes3"=>"three"}
+{"chanel1"=>"one", "chanel2"=>"two", "channel2"=>"two"}
1) Failure:
TestClusterCommandsOnPubSub#test_publish_psubscribe_punsubscribe_pubsub [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_pub_sub_test.rb:90]:
--- expected
+++ actual
@@ -1 +1 @@
-{"chanel1"=>"one", "chanel2"=>"two", "hermes3"=>"three"}
+{"chanel1"=>"one", "chanel2"=>"two", "channel2"=>"two"}
4) Failure:
TestClusterCommandsOnPubSub#test_publish_psubscribe_punsubscribe_pubsub [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_pub_sub_test.rb:90]:
--- expected
+++ actual
@@ -1 +1 @@
-{"chanel1"=>"one", "chanel2"=>"two", "hermes3"=>"three"}
+{"chanel1"=>"one", "chanel2"=>"two", "channel2"=>"two", "hermes3"=>"three"}
1) Failure:
TestClusterCommandsOnPubSub#test_publish_psubscribe_punsubscribe_pubsub [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_pub_sub_test.rb:90]:
--- expected
+++ actual
@@ -1 +1 @@
-{"chanel1"=>"one", "chanel2"=>"two", "hermes3"=>"three"}
+{"chanel1"=>"one", "chanel2"=>"two", "channel2"=>"two"}
97) Failure:
TestClusterCommandsOnPubSub#test_publish_psubscribe_punsubscribe_pubsub [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_pub_sub_test.rb:90]:
--- expected
+++ actual
@@ -1 +1 @@
-{"chanel1"=>"one", "chanel2"=>"two", "hermes3"=>"three"}
+{"chanel1"=>"one", "chanel2"=>"two", "channel2"=>"two", "hermes3"=>"three"}
Sentinel tests
We should wait for Redis Sentinel to be ready.
2) Error:
SentinelCommandsTest#test_sentinel_command_slaves:
NoMethodError: undefined method `[]' for nil:NilClass
/home/runner/work/redis-rb/redis-rb/test/sentinel_command_test.rb:30:in `test_sentinel_command_slaves'
3) Error:
SentinelTest#test_sentinel_slave_role_connection:
Redis::CannotConnectError: No sentinels available.
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:601:in `sentinel_detect'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:613:in `resolve_slave'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:570:in `resolve'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:347:in `establish_connection'
OBJECT command on cluster
It is just need to assert that it must be greater than 0. Type is not the matter.
https://github.com/redis/redis-rb/runs/753602487
Test / Sub (ubuntu-latest, 3.2, 2.3, ruby)
3) Failure:
TestClusterCommandsOnKeys#test_object [/home/runner/work/redis-rb/redis-rb/test/cluster_commands_on_keys_test.rb:54]:
Expected 0 to be an instance of Integer, not Fixnum.
JRuby timeout
It is just need to increase timeout.
https://github.com/redis/redis-rb/runs/741259913
Test / Sub (ubuntu-latest, 4.0, jruby-9.2.9.0, ruby)
155) Error:
TestDistributedBlockingCommands#test_brpop_timeout:
Redis::TimeoutError: Connection timed out
/home/runner/work/redis-rb/redis-rb/lib/redis/connection/ruby.rb:72:in `_read_from_socket'
/home/runner/work/redis-rb/redis-rb/lib/redis/connection/ruby.rb:57:in `gets'
/home/runner/work/redis-rb/redis-rb/lib/redis/connection/ruby.rb:398:in `read'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:275:in `block in read'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:263:in `io'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:274:in `read'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:127:in `block in call'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:243:in `block in process'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:387:in `ensure_connected'
/home/runner/work/redis-rb/redis-rb/lib/redis/client.rb:233:in `block in process'
Metadata
Metadata
Assignees
Labels
No labels