Skip to content

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #3685

@petyaslavova petyaslavova added the feature New feature label Sep 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for SSL verification flags configuration in Redis connections by introducing the ssl_verify_flags_config parameter. This allows users to customize SSL certificate verification behavior for both synchronous and asynchronous Redis connections.

  • Added ssl_verify_flags_config parameter to configure SSL verification flags
  • Implemented URL parsing support for the new SSL parameter
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
redis/connection.py Added ssl_verify_flags_config parameter and URL parsing logic for sync connections
redis/asyncio/connection.py Added ssl_verify_flags_config parameter and URL parsing logic for async connections
redis/client.py Added ssl_verify_flags_config parameter to Redis client constructor
redis/asyncio/client.py Added ssl_verify_flags_config parameter to async Redis client constructor
redis/cluster.py Added ssl_verify_flags_config to cluster SSL parameters list
redis/asyncio/cluster.py Added ssl_verify_flags_config parameter to async cluster client
tests/test_ssl.py Added test for SSL flags configuration in sync connections
tests/test_asyncio/test_ssl.py Added test for SSL flags configuration in async connections
tests/test_connection_pool.py Added tests for URL parsing of SSL flags configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asking for an option to deactivate x509 strict mode for TLS connections
1 participant