Adding handling of FAILING_OVER and FAILED_OVER events/push notifications#3716
Merged
petyaslavova merged 29 commits intofeat/hitless-upgrade-sync-standalonefrom Aug 19, 2025
Merged
Conversation
… tests for maintenance_events.py file
…tion pool - this should be a separate PR
… Refactored the maintenance events tests not to be multithreaded - we don't need it for those tests.
…ot processed in in Moving state. Tests are updated
…ply them during connect
…isting ones more generic
…e better retry_on_error handling on connection initialization.
e8643cd to
4c6eb44
Compare
8d7cc00 to
10ded34
Compare
Base automatically changed from
ps_hitless_upgrade_sync_redis
to
feat/hitless-upgrade-sync-standalone
August 18, 2025 07:57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Redis maintenance events system to handle two new cluster failover events: FAILING_OVER and FAILED_OVER. These events complement the existing migration events (MIGRATING/MIGRATED) by providing handling for cluster node failover scenarios.
Key changes:
- Added two new event classes:
NodeFailingOverEventandNodeFailedOverEvent - Integrated failover event handling into the existing maintenance event system using the same timeout relaxation mechanism as migration events
- Added comprehensive test coverage for the new events including integration tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| redis/maintenance_events.py | Added new failover event classes and integrated them into the event handler system |
| tests/test_maintenance_events.py | Added unit tests for the new event classes and updated existing tests to use the generalized event handling methods |
| tests/test_maintenance_events_handling.py | Added integration tests simulating failover events in the mock Redis communication layer |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vladvildanov
requested changes
Aug 18, 2025
vladvildanov
requested changes
Aug 18, 2025
vladvildanov
approved these changes
Aug 19, 2025
83f84cd
into
feat/hitless-upgrade-sync-standalone
1 check passed
petyaslavova
added a commit
that referenced
this pull request
Aug 25, 2025
petyaslavova
added a commit
that referenced
this pull request
Aug 29, 2025
…rade or maintenance procedures. (#3756) * Hitless upgrade: Support initial implementation for synchronous Redis client - no handshake, no failing over notifications support. (#3713) * Adding handling of FAILING_OVER and FAILED_OVER events/push notifications (#3716) * Hitless upgrade: Adding handshake command to enable the notifications after connection is established (#3735) * Hitless-Upgrade: Add handling of MOVING push notification with "null" host:port info. (#3751) --------- Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Adding handling of FAILING_OVER and FAILED_OVER events/push notifications