Convert the value to int type only if it exists in CLIENT INFO#3688
Merged
petyaslavova merged 3 commits intoredis:masterfrom Jul 11, 2025
Merged
Convert the value to int type only if it exists in CLIENT INFO#3688petyaslavova merged 3 commits intoredis:masterfrom
petyaslavova merged 3 commits intoredis:masterfrom
Conversation
Currently, client info will try to convert the set of keys to the int type without checking if it exists or not. For example, both `argv-mem` and `tot-mem` are introduced in 6.2, and force converting an non-existent value might cause an exception in older version. To keep the compatibility with the older/newer Redis server, we could just convert it only if the key exists.
Collaborator
|
Hi @git-hulk, apologies for the delayed response. I rebased your PR and will merge it tomorrow. |
Contributor
Author
|
@petyaslavova Thank you! I see one of CI is broke but it's related to upload the artifact and not relate to the current fix. Should I worry about this. |
Collaborator
@git-hulk No worries, it happens quite often lately. I restarted that job. |
petyaslavova
approved these changes
Jul 11, 2025
2 tasks
petyaslavova
pushed a commit
that referenced
this pull request
Jul 25, 2025
Currently, client info will try to convert the set of keys to the int type without checking if it exists or not. For example, both `argv-mem` and `tot-mem` are introduced in 6.2, and force converting an non-existent value might cause an exception in older or newer versions. To keep the compatibility with the older/newer Redis server, we could just convert it only if the key exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Currently, client info will try to convert the set of keys to the int type without checking if it exists or not. To keep compatibility with newer Redis servers or other Redis-compatible services, we could just convert it only if the key exists.