Redis Search/Aggregate improved type annotations#3676
Merged
petyaslavova merged 3 commits intoredis:masterfrom Jun 16, 2025
Merged
Redis Search/Aggregate improved type annotations#3676petyaslavova merged 3 commits intoredis:masterfrom
petyaslavova merged 3 commits intoredis:masterfrom
Conversation
Collaborator
|
Hi @luka-mikec, thank you very much for the time and effort you've put into this contribution — it's truly appreciated! |
Contributor
Author
Np, thanks for the quick review! |
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jun 30, 2025
* Fix ft.aggregate variable arguments type annotation * Fix ft.aggregate query type annotation
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jul 1, 2025
* Fix ft.aggregate variable arguments type annotation * Fix ft.aggregate query type annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixed type annotations for some of the search/aggregate functionality.