-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints for list commands #1917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
==========================================
- Coverage 93.02% 92.99% -0.03%
==========================================
Files 76 76
Lines 16537 16537
==========================================
- Hits 15383 15379 -4
- Misses 1154 1158 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure the old defaults (eg timeout=0) continue to work. Type hints if done correctly should work without unit test changes.
Our unit tests should just keep working. IMHO take out the unit test changes, and see what doesn't pass. This influences the type hint changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - let's validate it works with CI once I fix redismod docker
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.