-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function/Class method naming should use lowercase with underscores #1864
Labels
maintenance
Maintenance (CI, Releases, etc)
Comments
Andrew-Chen-Wang
changed the title
Class method naming should use lowercase with underscores
Function/Class method naming should use lowercase with underscores
Jan 5, 2022
@Andrew-Chen-Wang You're right. This comes as a direct result of the initial import of the module code into redis-py, and we should change that. Reviewing, it appears that all of the associated functions are internal only, meaning this is not a breaking change. @dvora-h Mind having a look? See below as an example of trying to identify these.
|
dssecret
pushed a commit
to Tornium/tornium
that referenced
this issue
Apr 1, 2022
Signed-off-by: dssecret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description: upon inspecting many of the new class methods, they don't follow Python convention. In addition to the PR for black and isort, I think the naming convention of these methods should be lowercase with underscores, for instance,
_append_scores
instead of_appendScores
The text was updated successfully, but these errors were encountered: