added support for bitfield command. #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecosta90
approved these changes
Dec 15, 2022
Contributor
@slice4e please correct the groups of test :) |
filipecosta90
suggested changes
Dec 15, 2022
Contributor
filipecosta90
left a comment
filipecosta90
left a comment
There was a problem hiding this comment.
2022-12-15 20:20:27 WARNING there is a difference between specified test-commands in the yaml (name=memtier_benchmark-1key-100MB-string-bitfield) and the ones we've detected ['get']!=['get', 'bitfield']
2022-12-15 20:20:27 WARNING there is a difference between specified test-groups in the yaml (name=memtier_benchmark-1key-100MB-string-bitfield) and the ones we've detected ['string']!=['bitmap']
filipecosta90
added
the
spec
filipecosta90
approved these changes
Dec 15, 2022
Collaborator
Author
|
I believe I fixed it. and pushed a new commit |
Contributor
Confirmed fixed in https://github.com/redis/redis-benchmarks-specification/actions/runs/3707733491/jobs/6284499636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for bitfield command.