Skip to content

Conversation

@killagu
Copy link
Contributor

@killagu killagu commented Sep 26, 2025

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@jit-ci
Copy link

jit-ci bot commented Sep 26, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@killagu killagu changed the title feat: add createClientPool for default modules feat: add default modules to createClientPool Sep 26, 2025
@nkaradzhov nkaradzhov self-assigned this Sep 29, 2025
@nkaradzhov
Copy link
Collaborator

Hey @killagu, thanks for your PR! Can you please explain what the underlying problem is that youre having?

@killagu
Copy link
Contributor Author

killagu commented Sep 29, 2025

When I use createClientPool, the pool.ft property is undefined. I would expect it to behave the same way as createClient, where the default module is automatically enabled.

@nkaradzhov nkaradzhov self-requested a review September 30, 2025 18:48
@nkaradzhov
Copy link
Collaborator

@killagu I see what you mean, this looks good, thanks for the contribution!

@nkaradzhov nkaradzhov merged commit dee7955 into redis:master Sep 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants