Skip to content

Conversation

@sjperkins
Copy link

This is likely an API-breaking change

@jit-ci
Copy link

jit-ci bot commented Nov 5, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@moticless
Copy link
Collaborator

moticless commented Nov 10, 2025

Hi @sjperkins,
Thanks for the PR! I'd suggest

  • Using destroy instead of close for better semantic accuracy. This callback doesn't just close a handle it destroys the entire context (Closes file/socket handles, Frees memory, Complete cleanup with the option to reopen/reuse).
  • Maybe accordingly rename respFileWriteDelete to respFileWriteDestroy and redisLoaderDelete to redisLoaderDestroy.
  • Since this breaks the API, we need to bump the major version per semver. Bump src/version.h to 2.0.0.
  • We also need to add basic CHANGELOG.md. Something like:
## [2.0.0] - 2025-11-10

### Breaking Changes
- **RdbxRespWriter**: Renamed `delete` member to `destroy` for C++ compatibility
  - `delete` is a reserved keyword in C++
  - `destroy` more accurately describes the operation (cleanup + memory deallocation)
  • I also noticed that on version upgrade "make clean" won't del old generated libs. We probably need to refine src/lib/makefile and src/ext/makefile with:
@rm -rvf $(LIB_DIR)/lib$(LIB_NAME).so.* $(TARGET_LIB_STATIC) ./*.o ./*.d;

LMK, if you prefer i will do it. thanks.

@sjperkins
Copy link
Author

sjperkins commented Nov 26, 2025

Hi @moticless. Apologies for the delayed response.

I believe I've addressed your comments. I'd appreciate a review of the changes.

@sjperkins sjperkins changed the title Rename RdbxRespWriter.delete RdbxRespWriter.close Rename methods and members containing the reserved C++ delete keyword to destroy Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RdbxRespWriter's delete member uses a reserved c++ keyword

2 participants