Skip to content

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Jul 25, 2025

No description provided.

@uglide uglide requested review from Copilot and ggivo July 25, 2025 10:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the format checking workflow to only validate formatting for newly added Java files instead of all changed files. This reduces the scope of format checking to focus on new contributions rather than modifications to existing files.

  • Updates the git diff command to use the --diff-filter=A flag to only include added files
  • Maintains the same file filtering for Java files (.java$ pattern)

@ggivo ggivo added maintenance skip-changelog Ignore pull request from release note churn Chore: Formatting and comment cleanup (non-functional change) labels Jul 25, 2025
@github-actions
Copy link

github-actions bot commented Jul 25, 2025

Test Results

  250 files  ± 0    250 suites  ±0   7m 2s ⏱️ - 2m 4s
4 622 tests  - 25  4 428 ✅  - 130  194 💤 +105  0 ❌ ±0 
2 458 runs   - 25  2 410 ✅  -  73   48 💤 + 48  0 ❌ ±0 

Results for commit 9f26200. ± Comparison against base commit 201f57f.

This pull request removes 25 tests.
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ advancedPubsubWithClientCache
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ cacheNotEmptyTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ cacheUsedTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ flushAll
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ flushAllWithSimpleMap
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ getNumEntriesTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ immutableCacheEntriesTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ invalidationOnCacheHitTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ invalidationTest
redis.clients.jedis.csc.JedisSentineledClientSideCacheTest ‑ simple
…
This pull request skips 105 tests.
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hexpireAndHttl
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hexpireAndHttlBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hexpireAtAndExpireTime
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hexpireAtAndExpireTimeBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpersist
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpersistBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpexpireAndHpttl
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpexpireAndHpttlBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpexpireAtAndPexpireTime
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest ‑ hpexpireAtAndPexpireTimeBinary
…

♻️ This comment has been updated with latest results.

@uglide uglide merged commit 3a2c704 into master Jul 25, 2025
10 of 14 checks passed
@uglide uglide deleted the imalinovskyi/format_new_files branch July 25, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

churn Chore: Formatting and comment cleanup (non-functional change) maintenance skip-changelog Ignore pull request from release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants