Skip to content

Deprecate Remove ShardedJedisPipeline class #2500 #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Deprecate Remove ShardedJedisPipeline class #2500 #2508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569a22f
Deprecate Remove ShardedJedisPipeline class #2500
sazzad16 Apr 11, 2021
436e421
putting back the tests
sazzad16 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/redis/clients/jedis/BinaryShardedJedis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,12 @@ public Long linsert(final byte[] key, final ListPosition where, final byte[] piv
return j.linsert(key, where, pivot, value);
}

/**
* @return
* @deprecated The support of {@link ShardedJedisPipeline} and this method will be removed in next
* major release.
*/
@Deprecated
public ShardedJedisPipeline pipelined() {
ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
pipeline.setShardedJedis(this);
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/redis/clients/jedis/ShardedJedisPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
import java.util.List;
import java.util.Queue;

/**
* @deprecated The support of {@link ShardedJedisPipeline} will be removed in next major release,
* due to several bugs and implementation issue.
*/
@Deprecated
public class ShardedJedisPipeline extends PipelineBase {
private BinaryShardedJedis jedis;
private List<FutureResult> results = new ArrayList<>();
Expand Down