Skip to content

Double timeout, avoid Tuple and more #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 30, 2021
Merged

Double timeout, avoid Tuple and more #2481

merged 11 commits into from
Mar 30, 2021

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented Mar 23, 2021 •
edited
Loading

(1) Implement double timeout:

Since Redis 6.0, timeout parameter of some blocking commands now supports double instead of integer.

  • Param type is changed for the methods that are yet to be released.
  • Similar methods are added for the existing (released) methods.
  • BRPOPLPUSH command is skipped as it is deprecated since Redis 6.2.

(2) Move away from Tuple:

The word Tuple means any finite number of elements. The way it is used not grammatically correct. We should move away from the class, introduce a proper name and avoid introducing wrong usage of the term.

  • KeyedTuple is just added targetting 3.6.0 for BZPOPMAX and BZPOPMIN commands. It has been renamed.

(3) Binary return type:

For binary methods, should we return custom objects or binary array(s) byte[]/List<byte[]>?

@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 23, 2021
@sazzad16 sazzad16 changed the title Double timeout Double timeout, avoid Tuple and more Mar 23, 2021
@sazzad16 sazzad16 requested review from dengliming and gkorland March 23, 2021 16:28
@dengliming

This comment was marked as off-topic.

Sign in to view
@mp911de
Copy link
Contributor

mp911de commented Mar 25, 2021

I'd suggest splitting the ticket into two topics and avoid breaking changes (return types) until Jedis 4.0. It would also make sense to have an overloaded method accepting double in addition to the long to not break existing code.

@sazzad16
Copy link
Contributor Author

@mp911de There are no exact breaking changes. For methods that exist in 3.5.2, there are overloading methods. Methods that are seemingly breaking are just merged for 3.6.0.

@mp911de
Copy link
Contributor

mp911de commented Mar 25, 2021

I see, thanks.

gkorland
gkorland reviewed Mar 28, 2021
View reviewed changes
sazzad16 added 2 commits March 28, 2021 12:01
@sazzad16
Remove UNUSABLE methods
47cf066
@sazzad16
Rename keysAndTimeout to getKeysAndTimeout
26fa016 
to have common name in both BinaryClient and BinaryJedis
sazzad16
sazzad16 commented Mar 28, 2021
View reviewed changes
sazzad16
sazzad16 commented Mar 28, 2021
View reviewed changes
@sazzad16 sazzad16 requested review from dengliming and gkorland March 28, 2021 06:33
@gkorland
Update package-info.java
29e3d66 
This package contains the classes that represent different Redis command arguments.
@sazzad16 sazzad16 merged commit 71dac36 into redis:master Mar 30, 2021
@sazzad16 sazzad16 deleted the double-timeout branch March 30, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gkorland gkorland gkorland approved these changes

@dengliming dengliming dengliming approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sazzad16 @dengliming @mp911de @gkorland