Skip to content

Add support for CLIENT KILL USER #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Add support for CLIENT KILL USER #2444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/redis/clients/jedis/params/ClientKillParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ public class ClientKillParams extends Params {
private static final String TYPE = "TYPE";
private static final String ADDR = "ADDR";
private static final String SKIPME = "SKIPME";
private static final String USER = "USER";

public static enum Type {
NORMAL, MASTER, SLAVE, PUBSUB;
Expand Down Expand Up @@ -57,4 +58,9 @@ public ClientKillParams skipMe(SkipMe skipMe) {
return this;
}

public ClientKillParams user(String username) {
addParam(USER, username);
return this;
}

}
11 changes: 11 additions & 0 deletions src/test/java/redis/clients/jedis/tests/commands/ClientCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,17 @@ public void killAddrIpPort() {
assertDisconnected(client);
}

@Test
public void killUser() {
Jedis client2 = new Jedis(hnp.getHost(), hnp.getPort(), 500);
client.aclSetUser("test_kill", "on", "+acl", ">password1");
client2.auth("test_kill", "password1");
long clients = jedis.clientKill(new ClientKillParams().user("test_kill"));
assertEquals(1, clients);
assertDisconnected(client2);
jedis.aclDelUser("test_kill");
}

private void assertDisconnected(Jedis j) {
try {
j.ping();
Expand Down