Skip to content

Add support for clientUnblock command #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2021
Merged

Add support for clientUnblock command #2424

merged 7 commits into from
Mar 17, 2021

Conversation

dengliming
Copy link

Resolves #2294

@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 12, 2021
@sazzad16 sazzad16 mentioned this pull request Mar 15, 2021
Merged
sazzad16
sazzad16 suggested changes Mar 17, 2021
View reviewed changes
dengliming added 2 commits March 17, 2021 21:22
@dengliming

This comment was marked as off-topic.

Sign in to view
sazzad16
sazzad16 suggested changes Mar 17, 2021
View reviewed changes
@sazzad16
Copy link
Contributor

The package name args is very similar to params

@dengliming What can you suggest us do now? params should stay dedicated for options. And it is not something that I to break things.

sazzad16
sazzad16 reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. WDYT about using @Nullable before UnblockType?

@dengliming

This comment was marked as off-topic.

Sign in to view
@dengliming

This comment was marked as off-topic.

Sign in to view
@sazzad16
Copy link
Contributor

Introduce @Nullable maybe better. Let user clearly know the params can be null. but we also need to import the annotation api(e.g. javax.annotation-api) right?

Hmm, you're right. Could you please add javadocs (in all methods) stating that UnblockType can be null? It's either this or adding new methods without UnblockType.

dengliming and others added 3 commits March 17, 2021 22:24
@dengliming
Merge remote-tracking branch 'upstream/master' into client_unblock
7fa9430 
# Conflicts:
#	src/main/java/redis/clients/jedis/BinaryClient.java
#	src/main/java/redis/clients/jedis/Protocol.java
@dengliming
Add javadoc
90e07c0
@sazzad16
Merge branch 'master' into client_unblock
c63bbfa
@sazzad16 sazzad16 merged commit 6f9fb61 into redis:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sazzad16 sazzad16 sazzad16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

Add support for clientUnblock command

2 participants

@dengliming @sazzad16