Add support for ACL SAVE/LOAD commands #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
suggested changes
Mar 11, 2021
src/main/java/redis/clients/jedis/commands/AdvancedBinaryJedisCommands.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 11, 2021 13:58
# Conflicts: # src/main/java/redis/clients/jedis/Protocol.java
sazzad16
suggested changes
Mar 11, 2021
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@dengliming Please add methods in Commands.java |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@dengliming Frankly, I'm not sure about this specific case. Historically, methods that can be used from Client.java are put in Commands.java. I'm just continuing to maintain it until we decide to drop it future. |
|
@dengliming Hmm, it seems all the ACL methods are out of sync. Okay, never mind. |
sazzad16
approved these changes
Mar 11, 2021
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2169