Skip to content

Add support INCR argument to ZADD command #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2021
Merged

Add support INCR argument to ZADD command #2415

merged 4 commits into from
Mar 11, 2021

Conversation

dengliming
Copy link

Resolves #2114

sazzad16
sazzad16 suggested changes Mar 10, 2021
View reviewed changes
sazzad16
sazzad16 suggested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason that you followed two styles in test codes?

Between,

r = z(...);
assert(r);

and

assert(z(...));

Is it possible to use only one?

@dengliming

This comment was marked as off-topic.

Sign in to view
@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 10, 2021
@sazzad16 sazzad16 merged commit 66c8556 into redis:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sazzad16 sazzad16 sazzad16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

please implements ZAddParams.incr() method!

2 participants

@dengliming @sazzad16