Skip to content

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland requested a review from sazzad16 February 28, 2021 16:12
@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #2391 (d59ba15) into master (264019b) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2391   +/-   ##
=========================================
  Coverage     58.47%   58.48%           
- Complexity     2161     2162    +1     
=========================================
  Files           106      106           
  Lines         10255    10255           
  Branches        480      480           
=========================================
+ Hits           5997     5998    +1     
  Misses         4057     4057           
+ Partials        201      200    -1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/redis/clients/jedis/JedisCluster.java 7.18% <0.00%> (ø) 23.00 <0.00> (ø)
...s/clients/jedis/JedisClusterConnectionHandler.java 82.97% <ø> (ø) 12.00 <0.00> (ø)
...in/java/redis/clients/jedis/JedisPoolAbstract.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...main/java/redis/clients/jedis/JedisPoolConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...in/java/redis/clients/jedis/JedisSentinelPool.java 67.20% <0.00%> (ø) 25.00 <0.00> (ø)
...clients/jedis/JedisSlotBasedConnectionHandler.java 28.57% <ø> (ø) 6.00 <0.00> (ø)
...ain/java/redis/clients/jedis/ShardedJedisPool.java 70.21% <ø> (ø) 6.00 <0.00> (ø)
src/main/java/redis/clients/jedis/JedisPool.java 57.25% <25.00%> (ø) 32.00 <2.00> (ø)
...n/java/redis/clients/jedis/BinaryJedisCluster.java 11.74% <33.33%> (ø) 33.00 <1.00> (ø)
...ava/redis/clients/jedis/JedisClusterInfoCache.java 61.90% <100.00%> (+0.68%) 23.00 <0.00> (+1.00)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264019b...d59ba15. Read the comment docs.

@sazzad16
Copy link
Contributor

@gkorland Should we consider it as breaking and mark for major release?

@gkorland
Copy link
Contributor Author

@sazzad16 is it breaking?

@sazzad16
Copy link
Contributor

sazzad16 commented Mar 1, 2021

@gkorland AFAIK, no. But my confidence level is a bit low on this.

@sazzad16
Copy link
Contributor

sazzad16 commented Mar 7, 2021

@gkorland Please resolve conflicts.

@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 7, 2021
@gkorland
Copy link
Contributor Author

gkorland commented Mar 8, 2021

@sazzad16 fixed conflicts

@sazzad16 sazzad16 merged commit 71a86d4 into master Mar 8, 2021
@sazzad16 sazzad16 deleted the GenericObjectPoolConfig branch March 8, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants