xrange make count optional #2380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SevereOverfl0w Does this approach fulfills yours requirement? |
|
@dengliming It'd be helpful if you could comment on #2305. Thanks |
# Conflicts: # src/main/java/redis/clients/jedis/BinaryClient.java
|
This would work, although a doc update would be helpful so it's clear this feature exists. Additionally, having an arity which drops the count altogether would make it clear that this method is available. |
added 3 commits
March 18, 2021 20:23
# Conflicts: # src/main/java/redis/clients/jedis/BinaryClient.java # src/test/java/redis/clients/jedis/tests/commands/StreamsCommandsTest.java
|
@dengliming I gave a long thought and finally I have decided to prefer #2460. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2261