Skip to content

Conversation

@walles
Copy link
Contributor

@walles walles commented Feb 2, 2021

To combat the constructor inflation.

With Java 8 (#2357) we could have used Duration rather than ints for the timeouts which would probably be nicer in the long run.

@sazzad16
Copy link
Contributor

@walles Currently we're trying to implement config pattern for the entire project (e.g. #2368). So, right now I'd consider only if it is done for all the necessary classes.

@walles
Copy link
Contributor Author

walles commented Feb 16, 2021

Sounds reasonable.

@walles walles closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants