Skip to content

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented Jan 30, 2021

This is a backward compatible alternate of #2033.

Though #2033 is already approved by two reviewers and tagged READY TO MERGE, I am having a second thought about it.

This seems to me a better approach than #2033.

Resolves #2030
Closes #2033

@yangbodong22011
Copy link
Contributor

@sazzad16 i vote for #2033, because this is the style of Jedis for unsupported commands, let them not exist instead of UnsupportedOperationException, for example: JedisCluster.java, there are no select or flushAll commands in.

@sazzad16
Copy link
Contributor Author

sazzad16 commented Feb 5, 2021

@yangbodong22011 Thank you for your vote. Let's say, the score is 1-1 for now.

@sazzad16
Copy link
Contributor Author

sazzad16 commented Feb 6, 2021

@yangbodong22011 FYI

... this is the style of Jedis for unsupported commands, let them not exist instead of UnsupportedOperationException, ...

The style can change in (near?!) future... #1545 #1545 (comment)

@sazzad16 sazzad16 merged commit a776efc into redis:master Feb 7, 2021
@sazzad16 sazzad16 deleted the watch-in-multi-bc branch February 7, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassCastException when transaction.watch(...) is used

3 participants