Document JedisClusterCommand.releaseConnection() as Nullable #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps both people (me!) and machines (IntelliJ) know how to call this method. Also, for IntelliJ users, if you find the "Constant conditions & exceptions" inspection and enable "Suggest @nullable annotation ... where nullable values are used" you will be informed about potential runtime NullPointerExceptions. A lot of things could probably be annotated, but I wanted to start with *something* to encourage future PRs to add nullability annotations where appropriate.
|
Would have helped me in #2355. |
|
@walles Include the change in your actual PR. But it is worth mentioning that it is unlikely to pass. We are trying to keep Jedis with least number of dependencies. |
|
In that case, consider it rejected because of the new dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps both people (me!) and machines (IntelliJ) know how to call this method.
Also, for IntelliJ users, if you find the
Constant conditions & exceptionsinspection and enableSuggest @Nullable annotation ... where nullable values are usedyou will be informed about potential runtimeNullPointerExceptions.A lot of things could probably be annotated, but I wanted to start with something to encourage future PRs to add nullability annotations where appropriate.