This class should not be package private but should be possible to ex… #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tend JedisFactory adnd JedisPool. Further, jedispool should create factory through a method to allow for overriding, alternatively be added as a constructor parameter. Current impl is bogged by constructors which should really be taking a ConfigParam instead.
|
Why did the tests fail? I only changed from package private to public. |
gkorland
previously approved these changes
Sep 13, 2020
|
@sazzad16 any objections? |
|
@gkorland without any test, I'm a bit concerned. but you can go ahead if want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tend JedisFactory adnd JedisPool. Further, jedispool should create factory through a method to allow for overriding, alternatively be added as a constructor parameter. Current impl is bogged by constructors which should really be taking a ConfigParam instead.