Skip to content

Conversation

@tgrall
Copy link
Contributor

@tgrall tgrall commented Aug 24, 2020

  • As I am looking at CSC implementation I think it is interesting to add this method.
  • I have not added any test as it is very basic update, let me know if I need to

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Params may contain byte[]. This solution does not handle this.

@tgrall
Copy link
Contributor Author

tgrall commented Aug 27, 2020

@sazzad16 thanks for your review.

I have updated the PR with the following:

  • replace the simple Map.toString() using a List (that is closer to how params are used by applications)
  • manage byte[]
  • add a simple test

@sazzad16 sazzad16 added this to the 3.5.0 milestone Dec 9, 2020
@sazzad16 sazzad16 modified the milestones: 3.5.0, 3.6.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants