Make getConnection abstract methods protected
#2203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
suggested changes
Jan 17, 2021
gkorland
approved these changes
Feb 7, 2021
sazzad16
approved these changes
Feb 7, 2021
sazzad16
changed the title
getConnection abstract methods publicgetConnection abstract methods protected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
getConnectionmethods inJedisClusterConnectionHandlerare package-private, they can only be implemented by classes inside theredis.clients.jedispackage, and the prevents third parties from subclassingJedisClusterConnectionHandler.Third parties may want to subclass
JedisClusterConnectionHandlerand related classes to add things like metrics or fault-tolerance measures. Making these methods public allows them to do so.