Skip to content

Fixed the logic that prevents all cluster slot requests sent to specific instances #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Fixed the logic that prevents all cluster slot requests sent to specific instances #1928

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6db7629
Fixed the logic that prevents all cluster slot requests sent to speci…
Jan 9, 2019
4b222ee
Replace each tab with two spaces.
Jan 10, 2019
286a88d
Merge branch 'master' into fixSlotWhenInitialization
dengliming Mar 24, 2021
2df9bcb
merge
dengliming Mar 24, 2021
3547198
reduce one possible import
sazzad16 Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/redis/clients/jedis/JedisClusterConnectionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package redis.clients.jedis;

import java.io.Closeable;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
import javax.net.ssl.HostnameVerifier;
Expand Down Expand Up @@ -117,8 +120,10 @@ public Map<String, JedisPool> getNodes() {
}

private void initializeSlotsCache(Set<HostAndPort> startNodes, JedisClientConfig clientConfig) {
List<HostAndPort> startNodeList = new ArrayList<>(startNodes);
Collections.shuffle(startNodeList);

for (HostAndPort hostAndPort : startNodes) {
for (HostAndPort hostAndPort : startNodeList) {
try (Jedis jedis = new Jedis(hostAndPort, clientConfig)) {
cache.discoverClusterNodesAndSlots(jedis);
return;
Expand Down