Skip to content

Conversation

@warrenzhu25
Copy link

No description provided.

@sazzad16
Copy link
Contributor

@warrenzhu25 Appreciate your effort. But, would you be able to keep the changes only limited to builder pattern and remove those formatting (e.g. import formatting), method renaming, method overloading changes? These can be in separate PRs. Otherwise, review and merge process would be harder. Thanks!

@warrenzhu25
Copy link
Author

@sazzad16 I got your point. But I would say most of my change are related with build pattern. I wish I could split the change into several commits, but some parts of it are indeed tightly decoupled. I have to change everything including the test to make compilation pass. Meanwhile, I'm working on the merge with master branch. I understand this contains many files and require many efforts to review. Could you go through it first? Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants