Skip to content

Rework/rethink about JedisSocketFactory with HostAndPort #2622

@sazzad16

Description

@sazzad16

Introducing JedisSocketFactory is a neat idea. However, it raises the question of how addressing should work. Right now, HostAndPort was the only mechanism to obtain a connection. With domain sockets, you need another way to connect to a node. I'd suggest introducing an interface and replace all usages of HostAndPort (breaking change, potentially a 4.0 topic) with that interface. Behind that interface, one can put addressing details so one could e.g. connect to Sentinel using domain sockets (or do other crazy things). You could even have an SSL implementation of JedisSocketFactory that uses SSL details from a SecureHostAndPort.

Thanks to @mp911de #2293 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions