JDK8 discussion

[smadasu]

Switching the version to 1.8 is trivial in pom.xml. What else is preventing us to do that?

[marcosnils]

I guess nothing. Wanna give it a shot?

[smadasu]

Sure.

[Martian101]

I encountered this error when using public String set(final String key, final String value, final SetParams params) method in JDK 1.8.0_111:

java.lang.ClassCastException: java.lang.Integer cannot be cast to [C

	at com.gexin.clients.jedis.params.set.SetParams.getByteParams(SetParams.java:75)
	at com.gexin.clients.jedis.BinaryClient.set(BinaryClient.java:106)
	at com.gexin.clients.jedis.Client.set(Client.java:53)
	at com.gexin.clients.jedis.Jedis.set(Jedis.java:136)

It seems that a type inference error occured when the type parameter is used in the return type:

  public <T> T getParam(String name) {
    if (params == null) return null;

    return (T) params.get(name);
  }

I can ensure this after some test both in JDK 1.7 and 1.8:

    @Test
    public void testT() {
        System.out.println(String.valueOf(getParam()));
    }

    public static <T> T getParam() {
        return (T) "AAA";
    }

[JensenZz]

@Martian101 maybe you can find your answer https://stackoverflow.com/questions/23155907/classcast-error-java-7-vs-java-8

[sazzad16]

Switching to JDK1.8 will be required if we want to upgrade Commons Pool to version 2.7.0.

References:

• Upgrade to Commons Pool 2.7.0 #2039
• upgrade commons-pool2 to 2.7.0 #2040

[sazzad16]

Resolved by #2396