Fix resource leaks and warnings in Junit tests

[smadasu]

Expected behavior

The Redis connections opened in unit tests should be closed properly. There are also lot of warnings in code which can be cleaned up easily

Actual behavior

The resources are not closed properly and may cause problems in running unit tests. Unnecessary suppresswarnings etc can be cleaned up

Steps to reproduce:

This is code enhancement

Redis / Jedis Configuration

Jedis version:

Latest unstable

Redis version:

Latest unstable

Java version:

1.7

[smadasu]

@marcosnils , I cannot use try with resources for java7. Why is Jedis still using 1.6 version of java?

[HeartSaVioR]

We discussed about version but seems like we forgot to change.
@marcosnils @xetorthio I guess we already discussed this - using at least JDK 7. Right?

[smadasu]

Here is part of pom.xml

    <plugins>
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-compiler-plugin</artifactId>
            <version>3.1</version>
            <configuration>
                <source>1.6</source>
                <target>1.6</target>
            </configuration>
        </plugin>

This uses 1.6

[smadasu]

@marcosnils @HeartSaVioR @xetorthio Do you think it's OK if I change as part of this pull request?

[HeartSaVioR]

Sorry I think it should be handled as another commit/issue/pull request for history.

[smadasu]

OK. I can create another PR for upgrading to 1.7. How likely is that PR merged into master? Because only then I can fix this issue.

[marcosnils]

fixed by #1334 for master branch.

[HeartSaVioR]

Using JDK7 is just a requirement for him to use try-with-finally, and he doesn't submit pull request regarding this. @smadasu Is this correct?

[smadasu]

That is correct

[HeartSaVioR]

OK. I reopen this.

[smadasu]

Thanks

[marcosnils]

Oh, sorry I thought you meant change the jdk support only in master. Well, Oracle added an extended support for the jdk 6 until the end of 2018 so I wouldn't recommend to drop support in before that time.
http://www.oracle.com/technetwork/java/eol-135779.html

[HeartSaVioR]

Well I think we can't change JDK version even in future if we're concerning Oracle paid support. :)
For public update, even public update for JDK 7 was end at last year (April 2015).