-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sharded pub/sub support via dedicated subscribers #1956
Merged
+728
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobymicroby
reviewed
Feb 20, 2025
bobymicroby
reviewed
Feb 20, 2025
There are some tests that need attention as well:
|
… cluster before doing a refresh
* Resubscribe shard channels * Polishing
* Rewrote the resubscribe logic for sharded PubSub by making the sharded subscriber group aware of the channels. * Added and extended the integration test cases in regards to sharded pubsub. * Skipping the Coveralls build step if the action run is not coming via a PR.
Added an example for sharded Pub/Sub
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
# [5.6.0](v5.5.0...v5.6.0) (2025-03-05) ### Features * Sharded pub/sub support via dedicated subscribers ([#1956](#1956)) ([963a395](963a395))
🎉 This PR is included in version 5.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used one subscriber connection per cluster instance, but the command
SSUBSCRIBE <channel>
needs to be executed against a node that is responsible for the hash slot that is derived from the channel name.This PR adds a ClusterSubscriberGroup whereby each subscriber in the group is responsible for one shard.