Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability for nat mapping through function #1948

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

maxbronnikov10
Copy link
Contributor

@maxbronnikov10 maxbronnikov10 commented Jan 21, 2025

The feature need when cluster nodes connected through dedicated subnet and you dont know exact host - only port
Also it would be useful if node failing and changing ip address

Changes:

  • Extend NatMap Type - union with object(previous) and function
  • Extend natMapper in Cluster for also work through function if it specified
  • Extend sentinelNatResolve in SentinelConnector for also work through function if it specified

Maybe fixes: #1003

@maxbronnikov10
Copy link
Contributor Author

@tishun Hello, sorry for tag. Can u pls review this PR? (I saw that u approved latest PR).
In iovalkey same PR merged - valkey-io/iovalkey#24

@tishun
Copy link
Contributor

tishun commented Jan 29, 2025

Hey @maxbronnikov10, seems like a good change for me.

@tishun tishun merged commit 3a04bee into redis:main Jan 29, 2025
5 checks passed
@maxbronnikov10
Copy link
Contributor Author

can u start release? For deploy last two commits

@tishun
Copy link
Contributor

tishun commented Jan 31, 2025

can u start release? For deploy last two commits

yes, we plan to release this in the following days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterAllFailedError: Failed to refresh slots cache.
3 participants