Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update cluster-key-slot to latest #1717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bag-man
Copy link

@bag-man bag-man commented Jan 31, 2023

When using ioredis, with the licence-compliance package, it fails due to a sub-dependency having an invalid licence string. The sub-dependency has fixed that, but ioredis hasn't updated to use it yet, resulting in this output:

ioredis (main) λ  npx license-compliance --allow "ISC;MIT;BSD-3-Clause;BSD-2-Clause;Apache-2.0;Python-2.0;MPL-2.0;LGPL-2.0;LGPL-3.0;LGPL-2.1;0BSD;Unlicense" --report detailed
Packages
└─ [email protected]
   ├─ Licenses: UNKNOWN
   ├─ License file: node_modules/cluster-key-slot/LICENSE
   ├─ Path: node_modules/cluster-key-slot
   └─ Repository: https://github.com/Salakar/cluster-key-slot

Upgrading cluster-key-slot, to the latest version, so that this PR that fixes the incorrect licence string is included.

@luin
Copy link
Collaborator

luin commented Feb 11, 2023

Looks like the tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants