fix: geo units must be lowercase up to Redis v7 #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Redis v7 various geo commands supported a case sensitive "unit" parameter (in Redis v7 and above it is case-insensitive). In particular, for clients running v6.2.7 and below the units m, km, ft, mi must be lowercase, or else an error is thrown:
ERR unsupported unit provided. please use m, km, ft, mi.While this is true for several geo-like commands it appears that in this library only the
geodistcommand explicitly types this parameter. However, the units here are specified to be uppercase which is incompatible with older versions. Since v7+ is case insensitive, this PR proposes to use lowercase for the sake of compatibility.