Remove support in deprecated TLS versions 1.0 and 1.1 #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-grunder @chayim @yossigo - I saw you plan to release a new hiredis version (1.2.0) soon, WDYT on adding it into it? |
chayim
reviewed
Jul 9, 2023
|
Can we include it with only a minor version bump? |
|
@michael-grunder Fully supportive of 1.2.0ing this. |
chayim
approved these changes
Jul 11, 2023
Merged
I don't think there's an obvious answer since we do not break the API or any documented guarantee about TLS compatibility. Practically speaking, it's unlikely that this will have a negative impact since TLSv1.2 has been around for a long time. So, I lean towards saying the security value here outweighs the compatibility issue, being vague as it is. |
Works for me, let's include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.