Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting gcc -BSymbolic due to symbol collisions #156

Merged
merged 24 commits into from
Feb 12, 2023
Merged

Reverting gcc -BSymbolic due to symbol collisions #156

merged 24 commits into from
Feb 12, 2023

Conversation

zalmane
Copy link
Contributor

@zalmane zalmane commented Feb 9, 2023

No description provided.

prokazov-redis and others added 24 commits January 11, 2023 21:07
@prokazov-redis
Implemented pack_bytes and pack_command.
8e122b8
@prokazov-redis
Bump version + make it work in a clean environment
be55776
@prokazov-redis
pack_command that passes redis-py test (*almost*)
2d45fb1
@prokazov-redis
Removed pack-bytes and added some tests.
fdb1314
@prokazov-redis
Removed pack-bytes and added some tests.
96e5d8e
@prokazov-redis
Merge branch 'pack_command'
143a81c
@prokazov-redis
even more clean up.
ff5ccaa
@prokazov
Re-factored tests and added a couple more ones.
83edbe8
@prokazov
1) Fix the compiler warning in pack.c
b54372d 
2) Fix a possible crash when running in Redis Gears.
@prokazov-redis
1) Fixed typo.
a5f8a3b 
2) Reverted version bump.
3) Added an entry to the changelog.
@prokazov-redis @prokazov
1) Fixed typo.
241000c 
2) Reverted version bump.
3) Added an entry to the changelog.
@prokazov-redis
Autopep-8 on setup.py
4a416d7
@prokazov
Drop extra link args
5807460
@zalmane
add conditional compile flags excluding windows and mac
8643b7c
@prokazov
Remove egg-info
3517354
@prokazov-redis
1) add conditional compile flags excluding windows and mac
05fe090 
2) add egg-info to gitignore
@prokazov
Actually use conditional compile flags
2ffa362
@prokazov-redis
Fix the Windows build.
1758fe9
@prokazov-redis
Re-factored setup.py and actually fixed the Windows build.
11fa235
@prokazov-redis
Apparently 'win' is not the same as win32.
d1a5ebe
@chayim
Merge branch 'master' into master
493d6a7
@prokazov
1) Don't use Bsymbolic linker arg
1f1af09 
2) Fix a build break on x86 platforms
@zalmane
revert back to using Bsymbolic
2905028
@zalmane
Merge branch 'master' of https://github.com/redis/hiredis-py
bd654f9
@zalmane
Copy link
Contributor Author

zalmane commented Feb 9, 2023

This PR adds a -BSymbolic flag to the linker. This is needed to avoid symbol collision in case we are importing hiredis from an embedded interpreter where an existing hiredis is also present. An example of this is RedisGears.
The collision causes a crash. This linker flag ensures that the bindings refer to the hiredis.so within the hiredis-py and avoids conflict with other hiredis libraries installed in other scopes.

@chayim chayim added the bug label Feb 12, 2023
@chayim chayim changed the title revert back to using BSymbolic for Redis Gears Reverting gcc -BSymbolic due to symbol collisions Feb 12, 2023
@chayim chayim merged commit a5574a9 into redis:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zalmane @chayim @prokazov-redis @prokazov