Fix for issues #2959 and #2960 #2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vmihailenco hi, could you help to take a look? Thanks a lot. |
Contributor
Author
|
@vmihailenco @monkey92t hi Sir, could you kindly help to take a look? Our project is blocked by this issue and don't want to maintain a private branch. Thanks a lot |
monkey92t
approved these changes
Apr 12, 2024
Collaborator
|
tks! |
EXPEbdodla
reviewed
Nov 14, 2024
| if err := cn.WithWriter(c.context(ctx), c.opt.WriteTimeout, func(wr *proto.Writer) error { | ||
| return writeCmds(wr, cmds) | ||
| }); err != nil { | ||
| if isBadConn(err, false, node.Client.getAddr()) { |
Contributor
There was a problem hiding this comment.
Is this correct? isBadConn() returning true for context cancelled errors as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issues #2959 and #2960