Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RediSearch Support #2801

Merged
merged 20 commits into from
Jun 26, 2024
Merged

RediSearch Support #2801

merged 20 commits into from
Jun 26, 2024

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

search_commands.go Outdated Show resolved Hide resolved
search_commands.go Outdated Show resolved Hide resolved
search_commands.go Outdated Show resolved Hide resolved
search_commands.go Outdated Show resolved Hide resolved
search_test.go Outdated Show resolved Hide resolved
search_test.go Outdated Show resolved Hide resolved
@chayim chayim added the feature label Dec 17, 2023
@jiangtao244
Copy link

how is this mr going?

vladvildanov
vladvildanov previously approved these changes Jun 25, 2024
@ofekshenawa ofekshenawa merged commit 244a3e2 into master Jun 26, 2024
10 checks passed
@quenbyako
Copy link

quenbyako commented Jul 18, 2024

@ofekshenawa @vladvildanov @chayim @jiangtao244 hi guys, sorry for interrupting, we stucked with using RediSearch in golang, under RESP3 protocol, especially with FT.AGGREGATE and FT.SEARCH commands:

I found that RESP3 testing code was commented for some reason, so in production it doesn't work at all (incorrect response parsing) — any luck with supporting third version of protocol?

If there is no pull request which fixes that problem, I created a fork with completed implementation of supporting "new" version of response, should I create a pull request for that?

@vladvildanov
Copy link
Collaborator

@quenbyako Thank you for reaching us out! Sorry for the bad experience, but we had to rollback our latest release that brings a support for RediSearch, so this functionality is considered non-finished. We're planning to release it very soon, but on the first stage it will be RESP2 only, RESP3 support will be a part of the release after this.

Stay tuned for update in near future!

@quenbyako
Copy link

@vladvildanov Glad that you responded so quick, thank you 😊🙏

Regarding to features rollback: Was this lack of compatibility for RESP3 documented somewhere? Cause I spent yesterday nearly 5 hours to undestand what's happened, and it was hell, there is completely no info about this one...

I implemented quick and dirty support for ft.aggregate command, please, take a look if you have some time, for our project redisearch is really important part, and I really want to collaborate with you guys on that feature addition, if that's possible 🤗

@vladvildanov
Copy link
Collaborator

@quenbyako The RESP3 will be partially compatible in near future and will be explained in the statement we prepare for community. We apologise that it forced you to dig into it, it was totally not planned to release it "that" way. We promise to properly communicate it with you 👌

@vladvildanov
Copy link
Collaborator

@quenbyako Join our discord community, there's a channel dedicated to go-redis as well https://discord.gg/zhvcaDMc

@quenbyako
Copy link

Hi @vladvildanov any update about this?

@vladvildanov
Copy link
Collaborator

@quenbyako Hey! Sorry for the delay, we're about to release Search support along with JSON in RESP2, will be included into next release

@sainad2222
Copy link

Hi @vladvildanov, Is there any ongoing issue that I can track for progress? Not able to join discord invite that was shared above too

@vladvildanov
Copy link
Collaborator

@sainad2222 Hey! Search support has been released and it's a part of 9.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants