Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SORT_RO command #2354

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

emilienkofman
Copy link

Add support for sort read only command, as suggested in discussion #2352 (comment)

@emilienkofman
Copy link
Author

For the record I've ran make test and found a few tests failing, not sure if it's related to my modifications or something not properly setup:

Summarizing 5 Failures:

[Fail] withConn [It] should replace the connection in the pool when there is no error 
/home/ekofman/Workspace/src/github.com/emilienkofman/redis/internal_test.go:324

[Fail] withConn [It] should replace the connection in the pool when there is an error not related to a bad connection 
/home/ekofman/Workspace/src/github.com/emilienkofman/redis/internal_test.go:337

[Fail] withConn [It] should remove the connection from the pool when it times out 
/home/ekofman/Workspace/src/github.com/emilienkofman/redis/internal_test.go:350

[Fail] Sentinel [It] should facilitate failover 
/home/ekofman/Workspace/src/github.com/emilienkofman/redis/sentinel_test.go:95

[Fail] Sentinel [BeforeEach] supports DB selection 
/home/ekofman/Workspace/src/github.com/emilienkofman/redis/sentinel_test.go:26

Ran 529 of 533 Specs in 88.188 seconds
FAIL! -- 524 Passed | 5 Failed | 2 Pending | 2 Skipped

@monkey92t
Copy link
Collaborator

good, Go / build (1.19.x) (pull_request) this error looks like a network unexpected error, we ignore it.

@monkey92t monkey92t merged commit d4e63b4 into redis:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants