Skip to content

Conversation

@valkirilov
Copy link
Member

Description

Bring back the loading indicator for tables in Browser Keys details.

Screen.Recording.2025-10-23.at.14.10.20.mov

How it was tested

  1. Go to Databases and open a connection to an existing database instance, or create a new one
  2. Go to the Browser page
  3. Open an existing key of type SET, SORTED SET, LIST, or HASH (all of which come with a table with members)
  4. Click on the refresh button in the header of the Key Details panel

Note: Usually, the indicator is shown, but it disappears very quickly if your connection is fast enough. You can make it stay for longer if you throttle your internet connection via the Dev Tools -> Network -> Throttle

image

@valkirilov valkirilov self-assigned this Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.18% 20127/24491
🟡 Branches 67.62% 8713/12886
🟡 Functions 76.27% 5350/7015
🟢 Lines 82.59% 19706/23859

Test suite run success

5226 tests passing in 681 suites.

Report generated by 🧪jest coverage report action from 17fac76

@valkirilov valkirilov marked this pull request as ready for review October 23, 2025 12:44
dantovska
dantovska previously approved these changes Oct 23, 2025
children?: ReactNode
style?: React.CSSProperties
className?: string
isAbsolutePositioned?: boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this name

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just absolute?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants