RI-6848: add info_command_is_disabled to analytics when INFO is disabled via ACL #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redisinsight/api/src/modules/database/database-connection.service.ts
Outdated
Show resolved
Hide resolved
| clientMetadata.databaseId, | ||
| { | ||
| databaseId: clientMetadata.databaseId, | ||
| ...(infoCommandIsDisabled ? { info_command_is_disabled: true } : {}), |
Collaborator
There was a problem hiding this comment.
if we will add isInfoCommandDisabled flag into RedisClient we can then avoid adding custom logic here and slightly simplify this. It become { isInfoComaandDisabled: client.isInfoCommandDisabled } or something similar
Collaborator
Author
There was a problem hiding this comment.
updated, however I pass no key/value in case of false
| if (error.message.includes(ERROR_MESSAGES.NO_INFO_COMMAND_PERMISSION)) { | ||
| try { | ||
| // Fallback to getting basic information from `hello` command | ||
| this.isInfoCommandDisabled = true; |
Collaborator
There was a problem hiding this comment.
Seems like you forgot to add this.isInfoCommandDisabled = true; into try black when info command wasn't fail.
Collaborator
There was a problem hiding this comment.
this.isInfoCommandDisabled = false I mean
Collaborator
Author
There was a problem hiding this comment.
updated default value and made it boolean; currently there's no need of a 3rd value
KrumTy
requested review from
ArtemHoruzhenko,
KIvanow,
dantovska,
pawelangelow,
pd-redis and
seth-riedel
KrumTy
merged commit cc96937
into
feature/RI-6658/no-perm-info-command
26 checks passed
KrumTy
added a commit
that referenced
this pull request
Feb 26, 2025
* RI-6849: fallback to hello command when connecting to db * RI-6849: refactor and test convertArrayOfKeyValuePairsToObject * RI-6849: expose getRedisInfo method * RI-6849: refactor getInfo method, expose from client * remove convertArrayOfKeyValuePairsToObject * fix failing unit test * update test * add default redis info * update static value * update default info * update default info * refactor getInfo * fix failing test * RI-6844: hide db overview metrics when data is not available (#4383) * RI-6848: add info_command_is_disabled to analytics when INFO is disabled via ACL (#4390) * RI-6848: add info_command_is_disabled to analytics when INFO is disabled via ACL * add isInfoCommandDisabled prop to RedisClient * preserve function signature * set default value for isInfoCommandDisabled * refactor getInfo * update: always call HELLO if INFO fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.