Feature/ri 7488 add linux arm64 build #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RI-7488: trigger build by push (test) * RI-7488: trigger build by push (test) * RI-7488: rename jobs * RI-7488: build linux only * RI-7488: cleanup test changes
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
valkirilov
approved these changes
Oct 23, 2025
| run: | | ||
| yarn package:prod --target linux-x64 --out ${packagePath}-x64.vsix | ||
| - name: Build linux package x64 (staging) |
There was a problem hiding this comment.
nit: I would put staging before production, although I see they're conditional and independent from each other. Also, I see that the rest of the files follow the same convention and you simply synced this one to look like the rest, so let's disregard this comment.
| sed -i "s/^RI_APP_FOLDER_NAME=.*/RI_APP_FOLDER_NAME='.redis-for-vscode-stage'/" ${{ env.envFile }} | ||
| yarn package:stage --target linux-x64 --out ${packagePath}-x64.vsix | ||
| - name: Download backend arm64 |
There was a problem hiding this comment.
This is a general note, and I don't think it's slow right now as well, but we can parallelize the ARM and AMD builds, because they are independent (correct me if I'm wrong).
There was a problem hiding this comment.
some space for improvements for the future
|
Verified that the ARM build of the extension for Linux works as expected. Extension installed successfully
Connecting to database
Adding and viewing keys
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added arm64 support for linux